Pivot
  1. Pivot
  2. PIVOT-762

Incorrect handling of TAB key in SuggestionPopup

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.1
    • Component/s: wtk-terra
    • Labels:
      None
    • Environment:
      Windows XP SP3, JRE 1.7 beta

      Description

      It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput.

      1. ASF.LICENSE.NOT.GRANTED--suggestion_popup_test.bxml
        1 kB
        Chris Bartlett
      2. suggest.patch
        5 kB
        Roger Whitcomb
      3. suggest2.patch
        5 kB
        Roger Whitcomb

        Activity

        Roger Whitcomb created issue -
        Hide
        Roger Whitcomb added a comment -

        This patch seems to work for my test case.

        Show
        Roger Whitcomb added a comment - This patch seems to work for my test case.
        Roger Whitcomb made changes -
        Field Original Value New Value
        Attachment suggest.patch [ 12483326 ]
        Hide
        Chris Bartlett added a comment -

        The patch looks fine to me for transferring focus TAB and SHIFT+TAB.
        Tested using
        http://svn.apache.org/repos/asf/pivot/trunk/tests/src/org/apache/pivot/tests/SuggestionPopupTest.java
        and a slightly modified version of its BXML file (attached).

        Show
        Chris Bartlett added a comment - The patch looks fine to me for transferring focus TAB and SHIFT+TAB. Tested using http://svn.apache.org/repos/asf/pivot/trunk/tests/src/org/apache/pivot/tests/SuggestionPopupTest.java and a slightly modified version of its BXML file (attached).
        Show
        Chris Bartlett added a comment - Modified BXML file to simplify testing with http://svn.apache.org/repos/asf/pivot/trunk/tests/src/org/apache/pivot/tests/SuggestionPopupTest.java
        Chris Bartlett made changes -
        Attachment suggestion_popup_test.bxml [ 12483435 ]
        Roger Whitcomb made changes -
        Assignee Roger Whitcomb [ rwhitcomb ]
        Hide
        Roger Whitcomb added a comment -

        Updated patch with just the TAB/SHIFT-TAB handling straightened out.

        Show
        Roger Whitcomb added a comment - Updated patch with just the TAB/SHIFT-TAB handling straightened out.
        Roger Whitcomb made changes -
        Attachment suggest2.patch [ 12483484 ]
        Hide
        Roger Whitcomb added a comment -

        Committed revision 1138592.

        Show
        Roger Whitcomb added a comment - Committed revision 1138592.
        Hide
        Roger Whitcomb added a comment -

        There are some ancillary issues which are/will be covered by other tickets. I believe this commit fixes the Tab/Shift-Tab issues for SuggestionPopup.

        Show
        Roger Whitcomb added a comment - There are some ancillary issues which are/will be covered by other tickets. I believe this commit fixes the Tab/Shift-Tab issues for SuggestionPopup.
        Roger Whitcomb made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Roger Whitcomb
            Reporter:
            Roger Whitcomb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4h
              4h
              Remaining:
              Remaining Estimate - 4h
              4h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development