Uploaded image for project: 'Pivot'
  1. Pivot
  2. PIVOT-71

Dash array (focused state) values are incorrect

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.1
    • 1.2
    • wtk
    • None
    • OpenJDK

    Description

      We've been using

      {0.0f, 2.0f} as our dash array for the skins that paint a dashed line to represent the focused state. These values are incorrect, and we got lucky in that Sun's graphics runtime interpreted them the way they did. The dash array {0.0f, 2.0f}

      means "repeatedly draw a dash of length 0.0f followed by a gap of 2.0f", which really means "don't draw anything"! However, because Sun's runtime interprets a dash of length zero at a non-zero thickness to yield a pixel hit. This interpretation is not shared by other JREs. NOTE, what we were going for was a dash of length 1 followed by a gap of length 1, and

      {1.0f, 1.0f}

      yields the exact same behavior on the Sun JRE as we had before, but it also yields correct behavior in other JREs. Thus, we should change all instances of the old dash arrays to the new.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tvolkert Todd Volkert
            tvolkert Todd Volkert
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment