[PIVOT-471] Make TableView.getSelectedRanges() iterable

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.5
• Component/s: wtk
• Labels: api-change
• Assignee: Unassigned
• Reporter: Dirk Moebius
• Created: 19/Apr/10 15:10
• Updated: 27/May/10 21:40
• Resolved: 23/Apr/10 16:15

Description

Iterating over the results of TableView.getSelectedRanges() is cumbersome because it returns a Sequence<Span> which is not iterable using a for-each loop. Instead it should return a List<Span>, which is iterable. Javadoc should state that the returned List is immutable.

Likewise for:

• ListView.getSelectedRanges()
• TreeView.getSelectedPaths()
• FileBrowser.getSelectedFiles()
• FileBrowserSheet.getSelectedFiles()

JavaDoc of TableView.getSelectedRows() should clearly state that this is a convenience method only, and that it allocates a result array on each invocation. Likewise for ListView.getSelectedItems().

See http://mail-archives.apache.org/mod_mbox/pivot-user/201004.mbox/[e-mail]%3e for motivation of this issue.