[PIRK-48] Pirk should pass all FindBugs tests

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Implemented
• Affects Version/s: 0.0.1
• Fix Version/s: 0.1.0
• Assignee: Tim Ellison
• Reporter: Tim Ellison
• Created: 12/Aug/16 10:53
• Updated: 14/Aug/16 17:36
• Resolved: 14/Aug/16 17:36

Description

FindBugs is a useful tool that static analyses Java code and flags potential bugs and improvements.

Pirk developers should ensure that FindBugs warnings are reviewed to ensure they are not identifying a real code bug. Bugs should be fixed, and false positives from FindBugs added to the project's filter.

There is a FindBugs plug-in for Maven that can ensure warnings are addressed for a successful compilation, and can add a site report containing the results of the static analysis. We should also consider adding this to the project pom file.

Issue Links

• links to: GitHub Pull Request #56