[PIO-99] `pio build` exits successfully even when compilation fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0-incubating
• Component/s: Build
• Labels: newbie
• Target Version/s: 0.12.0-incubating
• Assignee: Chan
• Reporter: Mars Hall
• Created: 21/Jun/17 17:19
• Updated: 11/Sep/17 02:23
• Resolved: 11/Sep/17 02:23

Description

The build command does not fail as expected. While not a big deal when working locally, it seems like this could be problematic for automated, continuous build/integration workflows.

$ pio build
…
[ERROR] [Engine$] [error] one error found
[ERROR] [Engine$] [error] (compile:compileIncremental) Compilation failed
[ERROR] [Engine$] [error] Total time: 5 s, completed Jun 21, 2017 9:59:55 AM
[ERROR] [Engine$] Return code of build command: /Users/mars.hall/Projects/predictionio-engine-ur/PredictionIO-dist/sbt/sbt  package assemblyPackageDependency is 1. Aborting.
[INFO] [Engine$] Looking for an engine...
[INFO] [Engine$] Found universal-recommender-assembly-0.5.0-deps.jar
[INFO] [Engine$] Found universal-recommender_2.11-0.5.0.jar
[INFO] [Engine$] Build finished successfully.
[INFO] [Pio$] Your engine is ready for training.

It certainly appears successful at the end, and exit code was 0.

Looking back for the error is not hard, but this behavior is problematic when composing pio build command into a shell script.