[PIG-4880] Overlapping of parameter substitution names inside&outside a macro fails with NPE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.16.0
• Component/s: parser
• Hadoop Flags: Reviewed
• Release Note: Now, macro argument/return names can overlap with parameter substitution names. Former value is taken for these cases.
• Assignee: Koji Noguchi
• Reporter: Koji Noguchi
• Created: 25/Apr/16 21:55
• Updated: 08/Jun/16 20:48
• Resolved: 12/May/16 16:49

Description

With

macro.pig

DEFINE mygroupby(REL, key) RETURNS G {
   %declare number 333;
   $G = GROUP $REL by $key parallel $number;
};

and

test.pig

-- equivalent of -param number=111
%declare number 111;

IMPORT 'macro.pig';
data = LOAD '1234.txt' USING PigStorage() AS (i: int);
result = mygroupby(data, i);
STORE result INTO 'test.out' USING PigStorage();

Fails with
error msg: <file myscript.pig, line 4> Macro inline failed for macro 'mygroupby'. Reason: null

Similarly, when macro param and command-line param overlap, it fails with
Macro inline failed for macro 'mygroupby'. Reason: Macro contains argument or return value number which conflicts with a Pig parameter of the same name.

Issue Links

• is related to: PIG-3359 Register Statements and Param Substitution in Macros