[PIG-4506] binstorage fails to write biginteger

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.15.0
• Component/s: data, impl
• Hadoop Flags: Reviewed
• Assignee: Savvas Savvides
• Reporter: Savvas Savvides
• Created: 14/Apr/15 09:54
• Updated: 07/Jun/15 03:48
• Resolved: 19/May/15 23:47

Description

When trying to store a biginteger using binstorage the following error is issued (The error might manifest elsewhere too):
java.lang.RuntimeException: Unexpected data type -1 found in stream

This is caused by a bug in the writeDatum method of the DataReaderWriter.java class. When writeDatum is called with a BigInteger as a argument, the BigInteger is converted to a byte[] and the writeDatum method is recursively called on the byte[]. writeDatum cannon handle byte[] objects but instead expects DataByteArray objects.

Suggested fix - wrap byte[] to DataByteArray:
change this line:
writeDatum(out, ((BigInteger)val).toByteArray());
to this:
writeDatum(out, new DataByteArray(((BigInteger)val).toByteArray()));