[PIG-4223] PigStorage using OptionBuilder is not thread-safe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Assignee: Prashant Kommireddi
• Reporter: Prashant Kommireddi
• Created: 08/Oct/14 20:29
• Updated: 08/Oct/14 21:05
• Resolved: 08/Oct/14 21:05

Description

While creating Options in the PigStorage constructor via populateValidOptions(), we started using OptionBuilder to create option corresponding to "overwrite" feature. OptionBuilder overuses static variables whose state can be manipulated by multiple threads. So when PigStorage tries to create a "longOpt", there might be some other thread that might be updating "longOpt" to null with a reset on the static variables. This does not seem to be safe for use within a multithreaded context.

Here is the ST

Cause5:

java.lang.IllegalArgumentException: must specify longopt

Cause5-StackTrace:

at org.apache.commons.cli.OptionBuilder.create(OptionBuilder.java:330)

at org.apache.pig.builtin.PigStorage.populateValidOptions(PigStorage.java:172)

at org.apache.pig.builtin.PigStorage.<init>(PigStorage.java:207)

... 36 shared with parent