Pig
  1. Pig
  2. PIG-3827

Custom partitioner is not picked up with secondary sort optimization

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.12.1, 0.13.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Custom partitioner is ignored currently in case of secondary sort optimization.

      1. PIG-3827-1.patch
        3 kB
        Daniel Dai
      2. PIG-3827-2.patch
        4 kB
        Daniel Dai
      3. PIG-3827-3.patch
        4 kB
        Daniel Dai

        Activity

        Prashant Kommireddi created issue -
        Daniel Dai made changes -
        Field Original Value New Value
        Attachment PIG-3827-1.patch [ 12636143 ]
        Daniel Dai made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.12.1 [ 12324970 ]
        Fix Version/s 0.13.0 [ 12324971 ]
        Daniel Dai made changes -
        Assignee Daniel Dai [ daijy ]
        Hide
        Daniel Dai added a comment -

        Sorry, miss WrongCustomPartitioner.java.

        Show
        Daniel Dai added a comment - Sorry, miss WrongCustomPartitioner.java.
        Daniel Dai made changes -
        Attachment PIG-3827-2.patch [ 12636148 ]
        Hide
        Prashant Kommireddi added a comment -

        +1

        Verified patch against the script that was broken due to this issue. Ran "test-commit", LGTM

        Show
        Prashant Kommireddi added a comment - +1 Verified patch against the script that was broken due to this issue. Ran "test-commit", LGTM
        Hide
        Prashant Kommireddi added a comment -

        Daniel Dai can you please add comments to the testcase before committing?

        Show
        Prashant Kommireddi added a comment - Daniel Dai can you please add comments to the testcase before committing?
        Hide
        Daniel Dai added a comment -

        Added comments.

        Show
        Daniel Dai added a comment - Added comments.
        Daniel Dai made changes -
        Attachment PIG-3827-3.patch [ 12636151 ]
        Hide
        Daniel Dai added a comment -

        Patch committed to trunk and 0.12 branch. Thanks Prashant for review!

        Show
        Daniel Dai added a comment - Patch committed to trunk and 0.12 branch. Thanks Prashant for review!
        Daniel Dai made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Prashant Kommireddi added a comment -

        Perfect, thanks Daniel.

        Show
        Prashant Kommireddi added a comment - Perfect, thanks Daniel.
        Prashant Kommireddi made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Daniel Dai
            Reporter:
            Prashant Kommireddi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development