Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-3752

Fix e2e Parallel test for Windows

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: e2e harness
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Parallel e2e test does not work for Windows (either activePerl or strawberryPerl). This is because IPC::Run module has limitation under Win32 (http://search.cpan.org/~toddr/IPC-Run-0.92/lib/IPC/Run.pm#Win32_LIMITATIONS). It will run into crash or deadlock. Fortunately cygwin perl does not use Win32 subsystem, and it does not have this issue. So we want to solve this by using cygwin perl.

        Activity

        Hide
        daijy Daniel Dai added a comment -

        Instruction for test environment:
        1. Install cygwin 1.7.28+ (earlier version has a bug), minimum core + perl, dev module
        2. Install perl module (Parallel::ForkManager, IPC::Run)
        To install it, open a cygwin terminal, use "cpan Parallel::ForkManager" etc to install.
        3. Need to put $CYGWIN_HOME/bin in PATH, after GnuWin32. Test will pick perl from cygwin, every other utilities still from GnuWin32.

        Show
        daijy Daniel Dai added a comment - Instruction for test environment: 1. Install cygwin 1.7.28+ (earlier version has a bug), minimum core + perl, dev module 2. Install perl module (Parallel::ForkManager, IPC::Run) To install it, open a cygwin terminal, use "cpan Parallel::ForkManager" etc to install. 3. Need to put $CYGWIN_HOME/bin in PATH, after GnuWin32. Test will pick perl from cygwin, every other utilities still from GnuWin32.
        Hide
        arpitgupta Arpit Gupta added a comment -

        +1 we have been running tests in parallel on windows with this patch and have found no regressions in the framework.

        Show
        arpitgupta Arpit Gupta added a comment - +1 we have been running tests in parallel on windows with this patch and have found no regressions in the framework.
        Hide
        rohini Rohini Palaniswamy added a comment -

        +1

        Show
        rohini Rohini Palaniswamy added a comment - +1
        Hide
        daijy Daniel Dai added a comment -

        Patch committed to both 0.13 branch and trunk. Thanks Arpit, Rohini for review!

        Show
        daijy Daniel Dai added a comment - Patch committed to both 0.13 branch and trunk. Thanks Arpit, Rohini for review!

          People

          • Assignee:
            daijy Daniel Dai
            Reporter:
            daijy Daniel Dai
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development