Pig
  1. Pig
  2. PIG-3156

TestSchemaTuple fails in trunk

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      To reproduce the issue, do:

      ant clean test -Dtestcase=TestSchemaTuple
      

      All 3 test cases fail with the following error:

      Caused by: java.lang.RuntimeException: Unable to compile
          at org.apache.pig.impl.util.JavaCompilerHelper.compile(JavaCompilerHelper.java:83)
          at org.apache.pig.data.SchemaTupleClassGenerator.compileCodeString(SchemaTupleClassGenerator.java:233)
          at org.apache.pig.data.SchemaTupleClassGenerator.generateSchemaTuple(SchemaTupleClassGenerator.java:186)
          at org.apache.pig.data.SchemaTupleFrontend$SchemaTupleFrontendGenHelper.generateAll(SchemaTupleFrontend.java:203)
          at org.apache.pig.data.SchemaTupleFrontend$SchemaTupleFrontendGenHelper.access$100(SchemaTupleFrontend.java:91)
          at org.apache.pig.data.SchemaTupleFrontend.copyAllGeneratedToDistributedCache(SchemaTupleFrontend.java:278)
          at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.JobControlCompiler.getJob(JobControlCompiler.java:656)
      

      I found that this was introduced by PIG-2764.

      1. PIG-3156.patch
        33 kB
        Cheolsoo Park

        Issue Links

          Activity

          Daniel Dai made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Cheolsoo Park made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Cheolsoo Park added a comment -

          Committed to trunk. Thank you Jonathan for the review!

          Show
          Cheolsoo Park added a comment - Committed to trunk. Thank you Jonathan for the review!
          Hide
          Jonathan Coveney added a comment -

          +1 thanks Cheolsoo!

          Show
          Jonathan Coveney added a comment - +1 thanks Cheolsoo!
          Cheolsoo Park made changes -
          Remote Link This issue links to "ReviewBoard (Web Link)" [ 12017 ]
          Cheolsoo Park made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Cheolsoo Park made changes -
          Attachment PIG-3156.patch [ 12568724 ]
          Hide
          Cheolsoo Park added a comment -

          Attached is a patch that fixes the test.

          Show
          Cheolsoo Park added a comment - Attached is a patch that fixes the test.
          Cheolsoo Park made changes -
          Assignee Cheolsoo Park [ cheolsoo ]
          Hide
          Jonathan Coveney added a comment -

          This makes sense. When it runs into a type that it doesn't recognize, it dies. Not sure why the DateTime stuff didn't kill it, though.

          I won't be able to code anything for probably about a week (I am in transit), but I'd be happy to review anything. I will try and bang out the fix if I have a spare moment though. I do not think it is a very complicated fix.

          Show
          Jonathan Coveney added a comment - This makes sense. When it runs into a type that it doesn't recognize, it dies. Not sure why the DateTime stuff didn't kill it, though. I won't be able to code anything for probably about a week (I am in transit), but I'd be happy to review anything. I will try and bang out the fix if I have a spare moment though. I do not think it is a very complicated fix.
          Cheolsoo Park made changes -
          Field Original Value New Value
          Link This issue is broken by PIG-2764 [ PIG-2764 ]
          Cheolsoo Park created issue -

            People

            • Assignee:
              Cheolsoo Park
              Reporter:
              Cheolsoo Park
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development