Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-3114

Duplicated macro name error when using pigunit

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.11
    • 0.12.0
    • parser
    • None
    • Reviewed
    • Clearing cache before calling PigServer::registerScript() to fix macro redefinition error.

    Description

      I'm using PigUnit to test a pig script within which a macro is defined.
      Pig runs fine on cluster but getting parsing error with pigunit.
      So I tried very basic pig script with macro and getting similar error.

      org.apache.pig.impl.logicalLayer.FrontendException: ERROR 1000: Error during parsing. <line 9> null. Reason: Duplicated macro name 'my_macro_1'
      at org.apache.pig.PigServer$Graph.parseQuery(PigServer.java:1607)
      at org.apache.pig.PigServer$Graph.registerQuery(PigServer.java:1546)
      at org.apache.pig.PigServer.registerQuery(PigServer.java:516)
      at org.apache.pig.tools.grunt.GruntParser.processPig(GruntParser.java:988)
      at org.apache.pig.pigunit.pig.GruntParser.processPig(GruntParser.java:61)
      at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:412)
      at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:194)
      at org.apache.pig.pigunit.pig.PigServer.registerScript(PigServer.java:56)
      at org.apache.pig.pigunit.PigTest.registerScript(PigTest.java:160)
      at org.apache.pig.pigunit.PigTest.assertOutput(PigTest.java:231)
      at org.apache.pig.pigunit.PigTest.assertOutput(PigTest.java:261)
      at FirstPigTest.MyPigTest.testTop2Queries(MyPigTest.java:32)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:597)
      at junit.framework.TestCase.runTest(TestCase.java:176)
      at junit.framework.TestCase.runBare(TestCase.java:141)
      at junit.framework.TestResult$1.protect(TestResult.java:122)
      at junit.framework.TestResult.runProtected(TestResult.java:142)
      at junit.framework.TestResult.run(TestResult.java:125)
      at junit.framework.TestCase.run(TestCase.java:129)
      at junit.framework.TestSuite.runTest(TestSuite.java:255)
      at junit.framework.TestSuite.run(TestSuite.java:250)
      at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
      at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
      at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
      at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
      at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
      at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
      at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
      Caused by: Failed to parse: <line 9> null. Reason: Duplicated macro name 'my_macro_1'
      at org.apache.pig.parser.QueryParserDriver.makeMacroDef(QueryParserDriver.java:406)
      at org.apache.pig.parser.QueryParserDriver.expandMacro(QueryParserDriver.java:277)
      at org.apache.pig.parser.QueryParserDriver.parse(QueryParserDriver.java:178)
      at org.apache.pig.PigServer$Graph.parseQuery(PigServer.java:1599)
      ... 30 more

      Pig script which is failing :

      test.pig
      DEFINE my_macro_1 (QUERY, A) RETURNS C {
          $C = ORDER $QUERY BY total DESC, $A;
      } ;
      
      data =  LOAD 'input' AS (query:CHARARRAY);
      
      queries_group = GROUP data BY query;
      
      queries_count = FOREACH queries_group GENERATE group AS query, COUNT(data) AS total;
      
      queries_ordered = my_macro_1(queries_count, query);
      
      queries_limit = LIMIT queries_ordered 2;
      
      STORE queries_limit INTO 'output';
      

      If I remove macro pigunit works fine. Even just defining macro without using it results in parsing error.

      Attachments

        1. bug_pig.tbz2
          1 kB
          Jerome Serrano
        2. PatchedPigTest.java
          3 kB
          Sajid Raza
        3. PIG-3114.patch
          2 kB
          Chetan Nadgire
        4. PIG-3114.patch
          2 kB
          Chetan Nadgire
        5. PIG-3114-2.patch
          4 kB
          Daniel Dai
        6. PIG-3114-3.patch
          6 kB
          Daniel Dai

        Issue Links

          Activity

            People

              daijy Daniel Dai
              chetan.nadgire Chetan Nadgire
              Votes:
              2 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: