Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-2793 Make Pig Work on Windows without Cygwin
  3. PIG-3024

TestEmptyInputDir unit test - hadoop version detection logic is brittle

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Won't Fix
    • 0.10.0
    • 0.12.0
    • build
    • None

    Description

      When the hadoop core version dependency is changed, TestEmptyInputDir almost always fails as coded. The issue is that it assumes all hadoop versions have MAPREDUCE-3606 fixed except two. It is more resilient to check families of releases for the fix than to check the release number directly. Right now, it is safer to assume the bug is present unless the release is one of those with the fix than it is to assume all releases have the fix except for two.

      Attachments

        1. PIG-3024.branch-0.10.1.patch
          2 kB
          John Gordon

        Activity

          jgordon John Gordon added a comment -

          Patch to increase flexibility to hadoop version

          jgordon John Gordon added a comment - Patch to increase flexibility to hadoop version
          jgordon John Gordon added a comment -

          Increases flexibility of the pig project to hadoop core prototype branches.

          jgordon John Gordon added a comment - Increases flexibility of the pig project to hadoop core prototype branches.
          if (Util.isHadoop23() || Util.isHadoop205())
          

          I think you meant Hadoop2_0 (Util.isHadoop2_0()) and not Util.isHadoop205 because the assert will fail with that.

          Do you need this in 0.11 or it can be moved to 0.12?

          rohini Rohini Palaniswamy added a comment - if (Util.isHadoop23() || Util.isHadoop205()) I think you meant Hadoop2_0 (Util.isHadoop2_0()) and not Util.isHadoop205 because the assert will fail with that. Do you need this in 0.11 or it can be moved to 0.12?

          Sorry. I missed that this is a windows subtask. 0.11 it is then.

          rohini Rohini Palaniswamy added a comment - Sorry. I missed that this is a windows subtask. 0.11 it is then.
          daijy Daniel Dai added a comment -

          No need on trunk. Mark it close.

          daijy Daniel Dai added a comment - No need on trunk. Mark it close.

          People

            jgordon John Gordon
            jgordon John Gordon
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: