Pig
  1. Pig
  2. PIG-2711

e2e harness: cache benchmark results between test runs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11, 0.10.1
    • Component/s: e2e harness
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It will be helpful to be able to store the benchmark results that are computed with "old pig" and reuse in subsequent runs.

      1. PIG-2711.patch
        3 kB
        Thomas Weise
      2. PIG-2711-2.patch
        0.5 kB
        Daniel Dai

        Activity

        Thomas Weise created issue -
        Hide
        Thomas Weise added a comment -

        For one this will speed up subsequent runs as we eliminate redundant pig runs (on some clusters running the harness at present takes up to 24 hours with local and mapred mode and additional internal tests).

        This feature can also be used to compare pig and hadoop versions based on archived benchmarks. While the harness currently allows to configure old and new pig and hadoop versions, it would be much simpler to configure the benchmark than recomputing it.

        Show
        Thomas Weise added a comment - For one this will speed up subsequent runs as we eliminate redundant pig runs (on some clusters running the harness at present takes up to 24 hours with local and mapred mode and additional internal tests). This feature can also be used to compare pig and hadoop versions based on archived benchmarks. While the harness currently allows to configure old and new pig and hadoop versions, it would be much simpler to configure the benchmark than recomputing it.
        Thomas Weise made changes -
        Field Original Value New Value
        Attachment PIG-2711.patch [ 12528383 ]
        Thomas Weise made changes -
        Attachment PIG-2711.patch [ 12528383 ]
        Thomas Weise made changes -
        Attachment PIG-2711.patch [ 12528384 ]
        Hide
        Daniel Dai added a comment -

        Patch committed to trunk. Thanks Thomas!

        Show
        Daniel Dai added a comment - Patch committed to trunk. Thanks Thomas!
        Daniel Dai made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.11 [ 12318878 ]
        Resolution Fixed [ 1 ]
        Hide
        Daniel Dai added a comment -

        Also commit to 0.10 branch as per Thomas' request.

        Show
        Daniel Dai added a comment - Also commit to 0.10 branch as per Thomas' request.
        Daniel Dai made changes -
        Fix Version/s 0.10.1 [ 12320547 ]
        Hide
        Jie Li added a comment -

        Do we need to update the documentation for setting up the e2e environment? I couldn't get it work due to the following error:

        (MR test job running succesfully...)
        ERROR TestDriver::run at : 470 Failed to run test FilterBoolean_1 <Unable to open file $

        {PH_BENCHMARK_CACHE_PATH}

        /FilterBoolean_1_benchmark.pig to write pig script, No such file or directory
        >

        Even I passed -DPH_BENCHMARK_CACHE_PATH=some_path, I still got the error:

        ERROR TestDriver::run at : 470 Failed to run test FilterBoolean_1 <Unable to open file /Users/JieLi/svn/pig/pig_benchmark_cache/FilterBoolean_1_benchmark.pig to write pig script, No such file or directory

        Show
        Jie Li added a comment - Do we need to update the documentation for setting up the e2e environment? I couldn't get it work due to the following error: (MR test job running succesfully...) ERROR TestDriver::run at : 470 Failed to run test FilterBoolean_1 <Unable to open file $ {PH_BENCHMARK_CACHE_PATH} /FilterBoolean_1_benchmark.pig to write pig script, No such file or directory > Even I passed -DPH_BENCHMARK_CACHE_PATH=some_path, I still got the error: ERROR TestDriver::run at : 470 Failed to run test FilterBoolean_1 <Unable to open file /Users/JieLi/svn/pig/pig_benchmark_cache/FilterBoolean_1_benchmark.pig to write pig script, No such file or directory
        Jie Li made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Thomas Weise added a comment -

        What you specify needs to be an existing path. Did you create /Users/JieLi/svn/pig/pig_benchmark_cache ?

        Show
        Thomas Weise added a comment - What you specify needs to be an existing path. Did you create /Users/JieLi/svn/pig/pig_benchmark_cache ?
        Hide
        Thomas Weise added a comment -

        Also, this was meant to be optional (see 0.10 branch). The build.xml in trunk may have additional modifications that don't set PH_BENCHMARK_CACHE_PATH empty by default.

        Show
        Thomas Weise added a comment - Also, this was meant to be optional (see 0.10 branch). The build.xml in trunk may have additional modifications that don't set PH_BENCHMARK_CACHE_PATH empty by default.
        Hide
        Jie Li added a comment -

        Thanks Thomas! That works. How about adding this to https://cwiki.apache.org/confluence/display/PIG/HowToTest?

        Show
        Jie Li added a comment - Thanks Thomas! That works. How about adding this to https://cwiki.apache.org/confluence/display/PIG/HowToTest?
        Hide
        Daniel Dai added a comment -

        Yes, it mean to be optional. Attach the patch for fix. Can you try it Jie?

        Show
        Daniel Dai added a comment - Yes, it mean to be optional. Attach the patch for fix. Can you try it Jie?
        Daniel Dai made changes -
        Attachment PIG-2711-2.patch [ 12531041 ]
        Hide
        Jie Li added a comment -

        Sure let me try it

        Show
        Jie Li added a comment - Sure let me try it
        Hide
        Daniel Dai added a comment -

        Tested. Commit PIG-2711-2.patch to 0.10/trunk.

        Show
        Daniel Dai added a comment - Tested. Commit PIG-2711 -2.patch to 0.10/trunk.
        Daniel Dai made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Daniel Dai made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3h 15m 1 Daniel Dai 21/May/12 08:23
        Resolved Resolved Reopened Reopened
        14d 11h 9m 1 Jie Li 04/Jun/12 19:32
        Reopened Reopened Resolved Resolved
        1d 10h 42m 1 Daniel Dai 06/Jun/12 06:15
        Resolved Resolved Closed Closed
        214d 18h 41m 1 Daniel Dai 06/Jan/13 23:57

          People

          • Assignee:
            Thomas Weise
            Reporter:
            Thomas Weise
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development