Pig
  1. Pig
  2. PIG-2516

sh command should behave like fs command

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Not A Problem
    • Affects Version/s: 0.9.1, 0.9.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Like fs command, sh command failure should result in query failure when run in batch mode. In interactive mode it should result in a warning.

      Also, sh command parsing seems to be faulty, according to Daniel, parser generated by PigScriptParser.jj would result in sh command using GetPath(), ie all sh commands might not be working.

        Activity

        Thejas M Nair created issue -
        Hide
        Dmitriy V. Ryaboy added a comment -

        Not sure I want the transient inability to clean up some local log or other trivial task to kill a whole pig job?

        Show
        Dmitriy V. Ryaboy added a comment - Not sure I want the transient inability to clean up some local log or other trivial task to kill a whole pig job?
        Hide
        Thejas M Nair added a comment -

        Yes, in some use cases you would not want the whole query to fail. But in such cases, you can write a shell command that does not result in failure. eg "rm -f" or "rm /nosuchfile || echo 'rm failed'".

        Show
        Thejas M Nair added a comment - Yes, in some use cases you would not want the whole query to fail. But in such cases, you can write a shell command that does not result in failure. eg "rm -f" or "rm /nosuchfile || echo 'rm failed'".
        Dmitriy V. Ryaboy made changes -
        Field Original Value New Value
        Labels newbie newbie simple
        Hide
        Devi Kumarappan added a comment -

        This is not an issue in the trunk version anymore.If sh command fails, then Pig exits with non zero code.

        Show
        Devi Kumarappan added a comment - This is not an issue in the trunk version anymore.If sh command fails, then Pig exits with non zero code.
        Thejas M Nair made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Not A Problem [ 8 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        94d 17h 5m 1 Thejas M Nair 11/May/12 21:47

          People

          • Assignee:
            Unassigned
            Reporter:
            Thejas M Nair
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development