Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.10.0
    • None
    • None

    Description

      Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.

      Attachments

        1. PIG-2191.2.patch
          34 kB
          Dmitriy V. Ryaboy
        2. PIG-2191.patch
          32 kB
          Dmitriy V. Ryaboy

        Issue Links

        Activity

          Attaching the patch. No unit tests, since the previous tests are sufficient.

          While I was in there, I changed the deprecated piggybank funcs that had this problem to be empty shells for their builtin variants.

          Please review.

          dvryaboy Dmitriy V. Ryaboy added a comment - Attaching the patch. No unit tests, since the previous tests are sufficient. While I was in there, I changed the deprecated piggybank funcs that had this problem to be empty shells for their builtin variants. Please review.
          rangadi Raghu Angadi added a comment -

          looks good.

          • JsonMetadata.java changes seem unrelated (whitespace only).
          • +1 for making deprecated classes just extend the non-deprecated ones.
          rangadi Raghu Angadi added a comment - looks good. JsonMetadata.java changes seem unrelated (whitespace only). +1 for making deprecated classes just extend the non-deprecated ones.

          Attaching a version that actually compiles.. forgot some imports last time.

          dvryaboy Dmitriy V. Ryaboy added a comment - Attaching a version that actually compiles.. forgot some imports last time.
          thejas Thejas Nair added a comment -

          +1 .
          If there are multiple udfs being used in a pig script, it will be very useful to have different warning counters for each of them. I will create a jira to support that feature and link it to this jira.

          thejas Thejas Nair added a comment - +1 . If there are multiple udfs being used in a pig script, it will be very useful to have different warning counters for each of them. I will create a jira to support that feature and link it to this jira.

          Committed to trunk. Thanks for the review.

          dvryaboy Dmitriy V. Ryaboy added a comment - Committed to trunk. Thanks for the review.

          @Thejas, is there a JIRA to support separate warning counters across multiple UDFs?

          prkommireddi Prashant Kommireddi added a comment - @Thejas, is there a JIRA to support separate warning counters across multiple UDFs?

          People

            dvryaboy Dmitriy V. Ryaboy
            dvryaboy Dmitriy V. Ryaboy
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment