Pig
  1. Pig
  2. PIG-2191

Reduce amount of log spam generated by UDFs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.

      1. PIG-2191.2.patch
        34 kB
        Dmitriy V. Ryaboy
      2. PIG-2191.patch
        32 kB
        Dmitriy V. Ryaboy

        Issue Links

          Activity

          Hide
          Prashant Kommireddi added a comment -

          @Thejas, is there a JIRA to support separate warning counters across multiple UDFs?

          Show
          Prashant Kommireddi added a comment - @Thejas, is there a JIRA to support separate warning counters across multiple UDFs?
          Hide
          Dmitriy V. Ryaboy added a comment -

          Committed to trunk. Thanks for the review.

          Show
          Dmitriy V. Ryaboy added a comment - Committed to trunk. Thanks for the review.
          Hide
          Thejas M Nair added a comment -

          +1 .
          If there are multiple udfs being used in a pig script, it will be very useful to have different warning counters for each of them. I will create a jira to support that feature and link it to this jira.

          Show
          Thejas M Nair added a comment - +1 . If there are multiple udfs being used in a pig script, it will be very useful to have different warning counters for each of them. I will create a jira to support that feature and link it to this jira.
          Hide
          Dmitriy V. Ryaboy added a comment -

          Attaching a version that actually compiles.. forgot some imports last time.

          Show
          Dmitriy V. Ryaboy added a comment - Attaching a version that actually compiles.. forgot some imports last time.
          Hide
          Raghu Angadi added a comment -

          looks good.

          • JsonMetadata.java changes seem unrelated (whitespace only).
          • +1 for making deprecated classes just extend the non-deprecated ones.
          Show
          Raghu Angadi added a comment - looks good. JsonMetadata.java changes seem unrelated (whitespace only). +1 for making deprecated classes just extend the non-deprecated ones.
          Hide
          Dmitriy V. Ryaboy added a comment -

          Attaching the patch. No unit tests, since the previous tests are sufficient.

          While I was in there, I changed the deprecated piggybank funcs that had this problem to be empty shells for their builtin variants.

          Please review.

          Show
          Dmitriy V. Ryaboy added a comment - Attaching the patch. No unit tests, since the previous tests are sufficient. While I was in there, I changed the deprecated piggybank funcs that had this problem to be empty shells for their builtin variants. Please review.

            People

            • Assignee:
              Dmitriy V. Ryaboy
              Reporter:
              Dmitriy V. Ryaboy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development