Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-896

Improve cmdline parsing of psql (PhoenixRuntime)

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.1.0, 4.1.0
    • None
    • None

    Description

      PhoenixRuntime (the class that is run via the "psql" command) does its own custom command-line parameter parsing, which has a number of limitations. One of the biggest issues is that it depends on the ordering of named parameters vs unnamed (i.e. file parameters), and starts performing actions as part of the command-line parameter parsing. This can lead to some files being run/imported, and then the tool stopping with an error due to an unexpected command-line parameter.

      An additional (but probably less important) issue is that the current parameter parsing is difficult to debug and test (there are currently no automated tests).

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            gabriel.reid Gabriel Reid
            gabriel.reid Gabriel Reid
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment