[PHOENIX-7316] Need close more Statements

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.2.0
• Fix Version/s: 5.2.1, 5.3.0
• Assignee: chaijunjie
• Reporter: chaijunjie
• Created: 18/May/24 11:27
• Updated: 26/Jun/24 21:38
• Resolved: 26/Jun/24 21:38

Description

After PHOENIX-6560, we find there are also many Statement not closed...

1. org.apache.phoenix.schema.MetaDataClient
incrementStatement
linkStatement
setAsync
setSync
tableUpsert
linkStatement
incrementStatement
tableUpsert

2. org.apache.phoenix.schema.task.Task
org.apache.phoenix.schema.task.Task#populateTasks
org.apache.phoenix.schema.task.Task#executeStatementAndGetTaskMutations

3. org.apache.phoenix.jdbc.PhoenixStatement.ExecutableShowTablesStatement#compilePlan

4. org.apache.phoenix.trace.PhoenixMetricsSink
org.apache.phoenix.trace.PhoenixMetricsSink#createTable
org.apache.phoenix.trace.PhoenixMetricsSink#putMetrics

5. org.apache.phoenix.trace.TraceWriter.FlushMetrics#addToBatch

6. org.apache.phoenix.trace.TraceWriter#createTable

7. org.apache.phoenix.trace.TraceReader#readAll

8. org.apache.phoenix.mapreduce.index.automation.PhoenixMRJobSubmitter#getCandidateJobs

 

so may be right, i will raise a PR try to fix all

Issue Links

• relates to: PHOENIX-7095 Implement Statement.closeOnCompletion() and fix related close() bugs
• relates to: PHOENIX-6560 Rewrite dynamic SQL queries to use Preparedstatement
• links to: PR