[PHOENIX-7230] Optimize rpc call to master if all indexes are migrated to new coprocs

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.3
• Fix Version/s: 5.2.0

Release Note

Use "phoenix.index.region.observer.enabled.all.tables" as "false" only if new index coprocs (GlobalIndexChecker, IndexRegionObserver etc) are not in use by all tables. Default value "true" indicates that we will not perform extra RPC call to retrieve TableDescriptor for all Mutations.

• Assignee: Palash Chauhan
• Reporter: Viraj Jasani
• Created: 23/Feb/24 00:26
• Updated: 23/Feb/24 23:58
• Resolved: 23/Feb/24 23:56

Description

If all the tables of the cluster have been migrated to the new index coprocs (GlobalIndexChecker, IndexRegionObserver), for every mutation, we should avoid making additional rpc call to master to retrieve TableDescriptor to determine if the table descriptor has GlobalIndexChecker coproc enabled:

at org.apache.phoenix.query.ConnectionQueryServicesImpl.getTableDescriptor(ConnectionQueryServicesImpl.java:605)
at org.apache.phoenix.util.IndexUtil.isGlobalIndexCheckerEnabled(IndexUtil.java:311)
at org.apache.phoenix.execute.MutationState.filterIndexCheckerMutations(MutationState.java:1680)
at org.apache.phoenix.execute.MutationState.sendBatch(MutationState.java:1255)
at org.apache.phoenix.execute.MutationState.send(MutationState.java:1186)
at org.apache.phoenix.execute.MutationState.send(MutationState.java:2028)
at org.apache.phoenix.execute.MutationState.commit(MutationState.java:1840)
at org.apache.phoenix.jdbc.PhoenixConnection$2.call(PhoenixConnection.java:841)
at org.apache.phoenix.jdbc.PhoenixConnection$2.call(PhoenixConnection.java:836)
at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
at org.apache.phoenix.jdbc.PhoenixConnection.commit(PhoenixConnection.java:836) 

We already use config "phoenix.index.region.observer.enabled" to disable/enable new index coproc during upgrade. The primary purpose of this config is to add/remove new or old index coprocs during upgrade process.

We can introduce new config "phoenix.index.region.observer.enabled.alltables" with default value true. Unless the config is disabled, we should avoid call to "IndexUtil#isGlobalIndexCheckerEnabled" within filterIndexCheckerMutations().

Issue Links

• links to: GitHub Pull Request #1833