[PHOENIX-6892] Add support for SqlAlchemy 2.0

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: python-phoenixdb-1.2.1
• Fix Version/s: python-phoenixdb-1.2.2
• Component/s: python, queryserver

Release Note

PhoenixDB now supports SqlAlchemy 1.3, 1,4 and 2.0.
SqlAlchemy is no longer an install dependency of PhoenixDB.

• Assignee: Istvan Toth
• Reporter: Istvan Toth
• Created: 06/Mar/23 05:29
• Updated: 20/Mar/23 13:55
• Resolved: 20/Mar/23 13:55

Description

Let's hope we can fix this without breaking SqlAchemy 1.x support

  /home/stoty/workspaces/apache-phoenix/phoenix-queryserver-parent/python-phoenixdb/phoenixdb/tests/test_sqlalchemy.py:161: SADeprecationWarning: The dbapi() classmethod on dialect classes has been renamed to import_dbapi().  Implement an import_dbapi() classmethod directly on class <class 'phoenixdb.sqlalchemy_phoenix.PhoenixDialect'> to remove this warning; the old .dbapi() classmethod may be maintained for backwards compatibility.
    return db.create_engine(urlunparse(url_parts), tls=tls, connect_args=connect_args)-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================================== short test summary info ========================================================================================
FAILED phoenixdb/tests/test_sqlalchemy.py::SQLAlchemyTest::test_connection - TypeError: Additional arguments should be named <dialectname>_<argument>, got 'autoload'
FAILED phoenixdb/tests/test_sqlalchemy.py::SQLAlchemyTest::test_reflection - sqlalchemy.exc.ObjectNotExecutableError: Not an executable object: 'drop table if exists us_population'
FAILED phoenixdb/tests/test_sqlalchemy.py::SQLAlchemyTest::test_schema_filtering - sqlalchemy.exc.ObjectNotExecutableError: Not an executable object: 'drop view if exists ALCHEMY_TEST_VIEW'
FAILED phoenixdb/tests/test_sqlalchemy.py::SQLAlchemyTest::test_textual - sqlalchemy.exc.ObjectNotExecutableError: Not an executable object: 'drop table if exists ALCHEMY_TEST'

Issue Links

• links to: GitHub Pull Request #122