Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6730

Revert protobuf-java version to 2.5.0

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Recently a dependabot commit has landed on connectors that upgrades the version of protobuf-java to 3.6.1

      I think that we should revert that.

      Part of the HBase 2 public API is that the public coprocessors use HBase 2 for communication.
      See https://hbase.apache.org/book.html#cpeps

      Using unshaded 3.6.1 in the connector breaks that contract.

      The shaded connector artifacts do not include protobuf-java, so the change is effectively a NOOP for the shaded connector JAR.

      However, in case someone depends on the core artifact, the change in the protobuf-java version may cause problems.

      Rajeshbabu Chintaguntla  I know that you have added the explicit dependency for the table metadata broadcast featrue, and that you've applied the dependabot PR, but I think that we should stick to the protobuf pulled in by HBase.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            stoty Istvan Toth
            stoty Istvan Toth
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment