[PHOENIX-6683] Surround the OR filters with parentheses while converting spark filters to phoenix expressions

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: connectors-6.0.0
• Component/s: spark-connector
• Assignee: Rajeshbabu Chintaguntla
• Reporter: Rajeshbabu Chintaguntla
• Created: 06/Apr/22 00:08
• Updated: 10/Jun/22 13:06
• Resolved: 07/Apr/22 15:35

Description

If there are mix of AND and OR filters in the query while converting the to phoenix filter from spark filters no parentheses got added to OR filters which is leading to wrong filter and finally getting wrong data.

For example if the filter is used is below

 where ENTITY_INSTANCE_ID = 40 and  (CANCELLATION_FLAG <> 'Y' OR CANCELLATION_FLAG IS NULL ) and CASE_MATCH_TYPE='M'

which is getting converted to an expression and leading to wrong result because result is always giving most of the records matching CANCELLATION_FLAG is not 'Y'

NOT  "CANCELLATION_FLAG" = 'Y' OR  "CANCELLATION_FLAG" IS NULL AND "CASE_MATCH_TYPE" IS NOT NULL AND "ENTITY_INSTANCE_ID" = 40 AND "ENTITY_INSTANCE_ID" IS NOT NULL AND "CASE_MATCH_TYPE" = 'M'

Issue Links

• links to: GitHub Pull Request #73