Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6660

Ship reload4j in queryserver assembly

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • queryserver-6.0.1
    • queryserver
    • None
    • Hide
      The Phoenix Query Server assembly now includes the reload4j and slf4j-reload4j jars.
      In order to avoid logging jar conflicts, Phoenix Query Server now has to be run with the phoenix-embedded-client jar variant, instead of the non-embedded phoenix-client jar.
      sqlline-thin.py now uses reload4j and the bin/logj.properties file for logginig.
      Show
      The Phoenix Query Server assembly now includes the reload4j and slf4j-reload4j jars. In order to avoid logging jar conflicts, Phoenix Query Server now has to be run with the phoenix-embedded-client jar variant, instead of the non-embedded phoenix-client jar. sqlline-thin.py now uses reload4j and the bin/logj.properties file for logginig.

    Description

      Queryserver currently doesn't ship any "real" logging backend, it only adds slf4j-simple.

      If you add the non embedded phoenix-client, then it will pick up the slf4j backend and slf4j from it, and work, but if you use phoenix-client-embedded, you only get the very limited slf4j-simple backend.

      Add reload4j to the assembly, and change the scripts to load those JARs.

      Also document that you should use the embedded client, and how to remove the bundled logging jars if you use the non-embedded client.

      Attachments

        Issue Links

          Activity

            stoty Istvan Toth added a comment - - edited

            Adding the logging jars explicitly also means that

            • we switch PQS to work with the embedded client jar, to avoid slf4j backend jar conflicts
            • we also add real logging to sqlline-thin.py, so that its logging works much like sqlline.py
            stoty Istvan Toth added a comment - - edited Adding the logging jars explicitly also means that we switch PQS to work with the embedded client jar, to avoid slf4j backend jar conflicts we also add real logging to sqlline-thin.py, so that its logging works much like sqlline.py
            stoty Istvan Toth added a comment -

            Committed to master.
            Thanks for the review apurtell .

            stoty Istvan Toth added a comment - Committed to master. Thanks for the review apurtell .

            People

              stoty Istvan Toth
              stoty Istvan Toth
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: