[PHOENIX-6611] Fix IndexTool -snap option and set VERIFIED in PhoenixIndexImportDirectReducer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.2.0
• Fix Version/s: 4.17.0, 5.2.0, 4.16.2, 5.1.3
• Component/s: core
• Assignee: Istvan Toth
• Reporter: Istvan Toth
• Created: 14/Dec/21 17:33
• Updated: 21/Sep/22 06:15
• Resolved: 05/Jan/22 12:19

Description

While fixing a trivial problem I introduced in PHOENIX-6601, I have expanded the ITs, and found a several bugs with IndexTool.

• Indexes generated by PhoenixIndexImportDirectReducer do not handle rows modified after the index table was created. (related to PHOENIX-5375, PHOENIX-5376)
• Global secondary index cells generated by PhoenixIndexImportDirectReducer do not have the VERIFIED flag set (similar to PHOENIX-6386)
• IndexTool cannot be run on the same table multiple withh -snapshot, unless the snapshot is manually deleted.
• Global secondary index cells on transactional tables do not have the VERIFIED flag set.
• Invalid snapshot name is generated for snapshot with namespace mapping enabled. (PHOENIX-6601 regression)

Some more test issues:

• IndexToolIT is not run with snapshots, or with namespace mapping enabled.
• The obsolete directApi option is all over the test code.

Issue Links

• is caused by: PHOENIX-6601 Fix IndexTools bugs with namespace mapping
• is related to: PHOENIX-6617 IndexRegionObserver should create mutations for the transforming table
• is related to: PHOENIX-5375 Building indexes from a snapshot image of a data table leads to incorrect timestamps
• is related to: PHOENIX-5376 Bulk loading data tables with indexes leads to index rows with incorrect timestamps
• is related to: PHOENIX-6386 Bulkload generates unverified index rows
• links to: GitHub Pull Request #1365