Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
thirdparty-1.1.0
-
None
Description
As found by Ankit during the release vote check:
* apache-rat:check check failed for following files (it's better we remove
them):-
phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/patches/
CLI-254-1.4.patch
I'm not sure we can or should an ASF header on a patch file, but we can exclude it from RAT.
phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/java/META-INF/MANIFEST.MF
This is unpacked from the commons-cli maven source artifact, exclude it from RAT
* Distribution link for the vote has a typo, the correct link seems to be
https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/
* RELEASE notes and changes.md seems to be not updated from the last
release.
It's a bug in the release scripts, I already have the fix, will open a JIRA for them ASAP.
* Signature and checksum - Ok
* Licence and Notice(nit: Copyright 2021) - Ok
Need to update