Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6287

Fix incorrect log in ParallelIterators.submitWork

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 5.1.0, 4.16.0
    • 5.1.0, 4.16.0
    • None
    • None

    Description

      In ParallelIterators.submitWork, the following log is critical but is meaningless:

      123                @Override
      124                public PeekingResultIterator call() throws Exception {
      125                    long startTime = EnvironmentEdgeManager.currentTimeMillis();
      126                    if (LOGGER.isDebugEnabled()) {
      127                        LOGGER.debug(LogUtil.addCustomAnnotations("Id: " + scanId + ", Time: " +
      128                            (EnvironmentEdgeManager.currentTimeMillis() - startTime) +
      129                            "ms, Scan: " + scan, ScanUtil.getCustomAnnotations(scan)));
      130                    }
      

      The log should be placed after the iterator.peek is called.

      Attachments

        1. PHOENIX-6287-4.x.patch
          3 kB
          chenglei

        Activity

          People

            comnetwork chenglei
            comnetwork chenglei
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: