[PHOENIX-6098] IndexPredicateAnalyzer wrongly handles pushdown predicates and residual predicates

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: connectors-6.0.0
• Component/s: hive-connector
• Assignee: Toshihiro Suzuki
• Reporter: Toshihiro Suzuki
• Created: 24/Aug/20 08:06
• Updated: 04/Aug/21 08:46
• Resolved: 25/Aug/20 12:26

Description

Currently, the following code of IndexPredicateAnalyzer is assuming that GenericUDFOPAnd always has 2 children nodes. I think this is wrong and it leads wrong results:
https://github.com/apache/phoenix-connectors/blob/5bd23ae2a0f70c3b3edf92a53780dafa643faf26/phoenix-hive3/src/main/java/org/apache/phoenix/hive/ql/index/IndexPredicateAnalyzer.java#L354-L363

Issue Links

• causes: PHOENIX-6524 Hive Connector returns emtpy AND expression when all children are pushed down
• links to: GitHub Pull Request #27