[PHOENIX-6085] Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 5.0.0, 4.15.0
• Fix Version/s: 5.2.1
• Labels: phoenix-hardening quality-improvement
• Assignee: Jing Yu
• Reporter: Chinmay Kulkarni
• Created: 19/Aug/20 19:11
• Updated: 17/Nov/23 23:58

Description

We already make this call inside CQSI.acquireUpgradeMutex() and then call writeMutexCell() which calls this again here.

We should move this to inside writeMutexCell() itself and throw UpgradeInProgressException if required there to avoid unnecessary expensive HBase admin API calls.