Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6082

No need to do checkAndPut when altering properties for a table or view with column-encoding enabled

    XMLWordPrintableJSON

Details

    Description

      ALTER TABLE/VIEW SET <property> follows the same code path as an add column. Thus, when column-encoding is enabled on the physical table, we will do a checkAndPut with the <physical table schema name>, <physical table name> (see this).

      This makes sense when we are adding a column since this causes an update to the encoded column qualifier counter of the base table and we want to prevent any concurrent changes to this field. However, when setting properties, we don't update the column qualifier counter so this extra checkAndPut is unnecessary. The server-side write-lock on the table header row followed by a sequence number check should be sufficient and is already done.

      Attachments

        1. PHOENIX-6082.4.x.000.patch
          11 kB
          Viraj Jasani
        2. PHOENIX-6082.master.000.patch
          11 kB
          Viraj Jasani

        Activity

          People

            vjasani Viraj Jasani
            ckulkarni Chinmay Kulkarni
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: