[PHOENIX-5984] Query timeout counter is not updated in all timeouts cases

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.15.0
• Fix Version/s: 5.1.0, 4.16.0
• Labels: metrics phoenix-hardening quality-improvement
• Assignee: Chinmay Kulkarni
• Reporter: Chinmay Kulkarni
• Created: 01/Jul/20 19:16
• Updated: 04/Sep/20 15:53
• Resolved: 15/Jul/20 22:53

Description

The OverallQueryMetrics query timeout counter and global query timeout counter are not updated if the query times out before getting the future corresponding to the scan i.e. if it times out at this point.
We only update relevant metrics if we catch a TimeoutException here if the future.get times out here. We should update the metrics in the first case as well.