[PHOENIX-5897] SingleKeyValueTuple.toString() returns unexpected result

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.0.0-alpha
• Fix Version/s: 5.1.0, 4.16.0
• Assignee: Chen Feng
• Reporter: Chen Feng
• Created: 15/May/20 07:21
• Updated: 23/Jun/20 12:31
• Resolved: 21/Jun/20 11:29

Description

In SingleKeyValueTuple.toString(), the code is shown as follows.
return "SingleKeyValueTuple[" + cell == null ? keyPtr.get() == UNITIALIZED_KEY_BUFFER ? "null" : Bytes.toStringBinary(keyPtr.get(),keyPtr.getOffset(),keyPtr.getLength()) : cell.toString() + "]";

actually, the code runs in the following order.
("SingleKeyValueTuple[" + cell) == null ? keyPtr.get() == UNITIALIZED_KEY_BUFFER ? "null" : Bytes.toStringBinary() : (cell.toString() + "]");

Therefore the result is weird.

BTW, value = condition1 ? condition2 ? X : Y : Z is also confusing, using if can be more clear.