Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-5772

Streamline the kerberos logic in thin client java code

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • queryserver-6.0.0
    • queryserver
    • None
    • Hide
      The java thin client library has been refactored. It no longer includes Hadoop libraries, and uses the Java SE Kerberos implementation directly.

      The sqlline library has also been removed from the thin client JAR.

      The standalone sqlline JAR is now included in the lib/ directory, and is now added to the classpath by the sqlline-thin.py script.

      Some default parameters that were picked up from hbase-site.xml by the java thin client are now also handled by sqlline-thin.py
      Show
      The java thin client library has been refactored. It no longer includes Hadoop libraries, and uses the Java SE Kerberos implementation directly. The sqlline library has also been removed from the thin client JAR. The standalone sqlline JAR is now included in the lib/ directory, and is now added to the classpath by the sqlline-thin.py script. Some default parameters that were picked up from hbase-site.xml by the java thin client are now also handled by sqlline-thin.py

    Description

      The thin client has logic for sqlline-thin that automatically enablies SPNEGO based on hbase and hadoop settings and whether or not the user is is logged into kerberos.

      According to my analysis, this is the only feature that this code provides. 

      When using the JAR as a JDBC driver, the kerberos code does not apply.

      However, this feature depends on hadoop, which carries the heavy cost bloating the thin client size and polluting its classpath.

      I propose removing the the feature from the Java code, and potentially implementing it in the sqlline-thin startup script.

      This would cut the JAR size by ~80%, and solve a lot of classpath problems for the users of the JDBC driver.

      This is based on discussion with elserj during the review of PHOENIX-5761

      Attachments

        Issue Links

          Activity

            People

              stoty Istvan Toth
              stoty Istvan Toth
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m