Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-5748

Simplify index update generation code for consistent global indexes

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1.0, 4.14.4, 4.16.0
    • Component/s: None
    • Labels:
      None

      Description

      The implementation of the new global index design by PHOENIX-5156 essentially introduced two coprocessors, IndexRegionObserver and GlobalIndexChecker. IndexRegionObserver is the counterpart of the existing Indexer coprocessor that the previous global indexing feature uses. It implements the indexing write path. GlobalIndexChecker implements the read verification and read repair that happens on the read path. One of the main objectives of the design behind new global indexing was to leverage as much existing indexing code as possible. This objective has been achieved greatly as the entire index table update generation code implemented by various classes (including PhoenixIndexBuilder, CachedLocalTable, NonTxIndexBuilder, IndexUpdateManager,  LocalTableState, ScannerBuilder, IndexMemStore and PhoenixIndexCodec) is leveraged as it is mainly. This objective has served us well to deliver the new indexing feature quickly. The leveraged code is very complex, over engineered, and inefficient, and is not bug free. It is very hard to maintain. It is time to replace the complex set of classes with something drastically simpler and more efficient for the new design.

        Attachments

        1. PHOENIX-5748.master.001.patch
          252 kB
          Kadir OZDEMIR
        2. PHOENIX-5748-4.x.001.patch
          253 kB
          Kadir OZDEMIR
        3. PHOENIX-5748-4.x-HBase-1.5.001.patch
          141 kB
          Kadir OZDEMIR

          Issue Links

            Activity

              People

              • Assignee:
                kozdemir Kadir OZDEMIR
                Reporter:
                kozdemir Kadir OZDEMIR
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 29h
                  29h