[PHOENIX-5697] Avoid resource leakage with try-with-resources

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.0, 4.15.1
• Fix Version/s: 5.1.0, 4.14.4, 4.16.0
• Labels: phoenix-hardening
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 24/Jan/20 19:11
• Updated: 06/May/20 05:27
• Resolved: 07/Feb/20 19:05

Description

There are places where we catch IOException in finally block while closing a closable resource or have to do redundant null check. If we could use try-with-resources to deal with closure of resources, that would not let us worry about catching IOException or NPE while closing the resources and would be a better replacement.

Issue Links

• links to: GitHub Pull Request #693