[PHOENIX-5677] Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1.0, 4.16.0
• Assignee: Geoffrey Jacoby
• Reporter: Geoffrey Jacoby
• Created: 13/Jan/20 23:32
• Updated: 24/Jan/20 05:23
• Resolved: 23/Jan/20 19:37

Description

Phoenix is inconsistent in using either system clock or EnvironmentEdgeManager to get current time. The EnvironmentEdgeManager is occasionally very useful in tests to control time deterministically without needing to sleep. Direct references to System.currentTimeMillis in non-test code should be switched over.

Issue Links

• links to: GitHub Pull Request #680
• links to: GitHub Pull Request #689