[PHOENIX-5654] String values (ALWAYS and NEVER) don't work for connection level config phoenix.default.update.cache.frequency

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.15.0, 5.1.0
• Fix Version/s: 5.1.0, 4.16.0
• Assignee: Nitesh Maheshwari
• Reporter: Nitesh Maheshwari
• Created: 29/Dec/19 01:52
• Updated: 06/May/20 02:48
• Resolved: 10/Jan/20 01:05

Description

While working on PHOENIX-5634, I noticed that the connection level property 'phoenix.default.update.cache.frequency' is being read in 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as follows:

long updateCacheFrequency = connection.getQueryServices().getProps().getLong(
    QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);

However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at https://phoenix.apache.org/language/index.html, the value for this config could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property should also follow the way the table-level property is read in 'TableProperty.UPDATE_CACHE_FREQUENCY'.

Issue Links

• blocks: PHOENIX-5634 Use 'phoenix.default.update.cache.frequency' from connection properties at query time
• links to: GitHub Pull Request #668