[PHOENIX-5635] Refactor curator dependency handling and clean up erroneous direct references

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.0
• Fix Version/s: 5.1.0
• Assignee: Istvan Toth
• Reporter: Istvan Toth
• Created: 17/Dec/19 15:01
• Updated: 10/Feb/21 10:01
• Resolved: 17/Dec/19 16:13

Description

The way we currently override the Omid curator version by excluding it from omid, and directly depending on is needlessly complex.

It is much more straightforward to use dependencyManagement for this purpose.

Also there a few places in the code that refer to the shaded guava List class in curator, instead of directly to guava for no discernible reason (probably IDE automation chose the curator class)

 

Issue Links

• relates to: PHOENIX-5758 Apply cleanups to 4.x branch
• links to: GitHub Pull Request #656