[PHOENIX-5541] Redundant Global Mutable Index Writes on Legacy Indexer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.15.0, 5.1.0, 4.14.3
• Fix Version/s: 4.15.0, 5.1.0, 4.14.4
• Assignee: Geoffrey Jacoby
• Reporter: Geoffrey Jacoby
• Created: 22/Oct/19 20:38
• Updated: 21/Dec/19 00:57
• Resolved: 28/Oct/19 20:57

Description

In the inaccurately-named IndexWriter.writeAndKillYourselfOnFailure, there's the following code:

public void writeAndKillYourselfOnFailure(Collection<Pair<Mutation, byte[]>> indexUpdates, boolean allowLocalUpdates, int clientVersion) throws IOException { 
// convert the strings to htableinterfaces to which we can talk and group by TABLE Multimap<HTableInterfaceReference, Mutation> toWrite = resolveTableReferences(indexUpdates); 
writeAndKillYourselfOnFailure(toWrite, allowLocalUpdates, clientVersion); writeAndHandleFailure(toWrite, allowLocalUpdates, clientVersion); 
}

writeAndKillYourselfOnFailure and writeAndHandleFailure seem to be identical, which means that calling them both will result in the same index Cells being written twice. This shouldn't affect correctness, but it will affect performance and (temporarily, until compaction) storage

Issue Links

• links to: GitHub Pull Request #604