Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-5541

Redundant Global Mutable Index Writes on Legacy Indexer

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.15.0, 5.1.0, 4.14.3
    • Fix Version/s: 4.15.0, 5.1.0, 4.14.4
    • Component/s: None
    • Labels:
      None

      Description

      In the inaccurately-named IndexWriter.writeAndKillYourselfOnFailure, there's the following code:

      public void writeAndKillYourselfOnFailure(Collection<Pair<Mutation, byte[]>> indexUpdates, boolean allowLocalUpdates, int clientVersion) throws IOException { 
      // convert the strings to htableinterfaces to which we can talk and group by TABLE Multimap<HTableInterfaceReference, Mutation> toWrite = resolveTableReferences(indexUpdates); 
      writeAndKillYourselfOnFailure(toWrite, allowLocalUpdates, clientVersion); writeAndHandleFailure(toWrite, allowLocalUpdates, clientVersion); 
      }
      

      writeAndKillYourselfOnFailure and writeAndHandleFailure seem to be identical, which means that calling them both will result in the same index Cells being written twice. This shouldn't affect correctness, but it will affect performance and (temporarily, until compaction) storage

        Attachments

        1. PHOENIX-5541.patch
          4 kB
          Geoffrey Jacoby

          Issue Links

            Activity

              People

              • Assignee:
                gjacoby Geoffrey Jacoby
                Reporter:
                gjacoby Geoffrey Jacoby
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m