-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12968209/PHOENIX-5269-4.14-HBase-1.4.patch
against 4.14-HBase-1.4 branch at commit d9057de0e5ec7f1b89b6586f6c03f73163fd01ee.
ATTACHMENT ID: 12968209
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javac. The patch appears to cause mvn compile goal to fail .
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[55,47] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[82,13] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[146,29] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,22] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,57] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,22] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,57] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,22] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,63] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[482,114] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,23] cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,64] cannot find symbol
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.0:compile (default-compile) on project phoenix-core: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[55,47] cannot find symbol
[ERROR] symbol: class AccessChecker
[ERROR] location: package org.apache.hadoop.hbase.security.access
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[82,13] cannot find symbol
[ERROR] symbol: class AccessChecker
[ERROR] location: class org.apache.phoenix.coprocessor.PhoenixAccessController
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[146,29] cannot find symbol
[ERROR] symbol: class AccessChecker
[ERROR] location: class org.apache.phoenix.coprocessor.PhoenixAccessController
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,22] cannot find symbol
[ERROR] symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,57] cannot find symbol
[ERROR] symbol: method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR] location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,22] cannot find symbol
[ERROR] symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,57] cannot find symbol
[ERROR] symbol: method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR] location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,22] cannot find symbol
[ERROR] symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,63] cannot find symbol
[ERROR] symbol: method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR] location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[482,114] cannot find symbol
[ERROR] symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,23] cannot find symbol
[ERROR] symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,64] cannot find symbol
[ERROR] symbol: method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR] location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :phoenix-core
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2570//console
This message is automatically generated.
Are you going to want to fix this in the 1.3 branches? kiran.maturi tdsilva If so you'll need an HBase JIRA for backporting AccessChecker to branch-1.3.