[PHOENIX-5269] PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.14.1, 4.14.2
• Fix Version/s: 4.15.0, 5.1.0, 4.14.2
• Assignee: Kiran Kumar Maturi
• Reporter: Andrew Kyle Purtell
• Created: 05/May/19 21:16
• Updated: 21/Dec/19 00:56
• Resolved: 20/Jun/19 06:46

Description

PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks.

In HBase, every RegionServer's AccessController maintains a local cache of permissions. At startup time they are initialized from the ACL table. Whenever the ACL table is changed (via grant or revoke) the AC on the ACL table "broadcasts" the change via zookeeper, which updates the cache. This is performed and managed by TableAuthManager but is exposed as API by AccessChecker. AccessChecker is the result of a refactor that was committed as far back as branch-1.4 I believe.

Phoenix implements its own access controller and is using the client API AccessControlClient instead. AccessControlClient does not cache nor use the ZK-based cache update mechanism, because it is designed for client side use.

The use of AccessControlClient instead of AccessChecker is not scalable. Every permissions check will trigger a remote RPC to the ACL table, which is generally going to be a single region hosted on a single RegionServer.

Issue Links

• is related to: PHOENIX-5267 With namespaces enabled Phoenix client times out with high loads
• relates to: HBASE-22374 Backport AccessChecker refactor to branch-1.3
• relates to: HBASE-22375 Promote AccessChecker to LimitedPrivate(Coprocessor)
• supercedes: PHOENIX-5267 With namespaces enabled Phoenix client times out with high loads
• supercedes: PHOENIX-5149 Set minimum HBase 1.4 version to 1.4.3