[PHOENIX-5188] IndexedKeyValue should populate KeyValue fields

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0.0, 4.14.1
• Fix Version/s: 4.15.0, 5.1.0, 4.14.2, 5.0.1
• Assignee: Geoffrey Jacoby
• Reporter: Geoffrey Jacoby
• Created: 12/Mar/19 02:57
• Updated: 30/May/19 18:40
• Resolved: 12/Mar/19 23:54

Description

IndexedKeyValue subclasses the HBase KeyValue class, which has three primary fields: bytes, offset, and length. These fields aren't populated by IndexedKeyValue because it's concerned with index mutations, and has its own fields that its own methods use.

However, KeyValue and its Cell interface have quite a few methods that assume these fields are populated, and the HBase-level factory methods generally ensure they're populated. Phoenix code should do the same, to maintain the polymorphic contract. This is important in cases like custom ReplicationEndpoints where HBase-level code may be iterating over WALEdits that contain both KeyValues and IndexKeyValues and may need to interrogate their contents.

Since the index mutation has a row key, this is straightforward.

Issue Links

• is related to: HBASE-22032 KeyValue validation should check for null byte array