[PHOENIX-5080] Index becomes Active during Partial Index Rebuilder if Index Failure happens

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Resolved
• Affects Version/s: 4.14.1
• Fix Version/s: 4.15.0, 5.1.0, 4.14.2
• Assignee: Mihir Monani
• Reporter: Mihir Monani
• Created: 22/Dec/18 12:28
• Updated: 30/May/19 18:40
• Resolved: 05/Feb/19 01:35

Description

After PHOENIX-4130 and PHOENIX-4600 , If there is Index failure during Partial Index Rebuild, Rebuilder will try again to write Index updates. If it succeeds then it will transition Index from INACTIVE to ACTIVE, even before Rebuilder finishes.

Here is where it goes wrong, I think :- 

PhoenixIndexFailurePolicy.java :- 
public static void doBatchWithRetries(MutateCommand mutateCommand,
            IndexWriteException iwe, PhoenixConnection connection, ReadOnlyProps config) throws IOException {
....
    while (canRetryMore(numRetry++, maxTries, canRetryUntil)) {
    ...
        handleIndexWriteSuccessFromClient(iwe, connection);
    ...
    }
}
....
private static void handleIndexWriteSuccessFromClient(IndexWriteException indexWriteException, PhoenixConnection conn) {
        handleExceptionFromClient(indexWriteException, conn, PIndexState.ACTIVE);
}

 

 

 

Issue Links

• relates to: PHOENIX-5079 PhoenixIndexMetaData.isIndexRebuild gives wrong results in Partial Index Rebuilding