[PHOENIX-5055] Split mutations batches probably affects correctness of index data

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 5.0.0, 4.14.1
• Fix Version/s: 5.1.0, 4.14.2, 5.0.1
• Assignee: Jaanai Zhang
• Reporter: Jaanai Zhang
• Created: 03/Dec/18 13:37
• Updated: 15/Jul/19 11:14
• Resolved: 05/Jan/19 14:22

Description

In order to get more performance, we split the list of mutations into multiple batches in MutationSate.  For one upsert SQL with some null values that will produce two type KeyValues(Put and DeleteColumn),  These KeyValues should have the same timestamp so that keep on an atomic operation for corresponding the row key.

ConcurrentTest.java produced some random upsert/delete SQL and concurrently executed, some SQL snippets as follows:

1149:UPSERT INTO ConcurrentReadWritTest(A,C,E,F,G) VALUES ('3826','2563','3052','3170','3767');

1864:UPSERT INTO ConcurrentReadWritTest(A,B,C,D,E,F,G) VALUES ('2563','4926','3526','678',null,null,'1617');

2332:UPSERT INTO ConcurrentReadWritTest(A,B,C,D,E,F,G) VALUES ('1052','2563','1120','2314','1456',null,null);

2846:UPSERT INTO ConcurrentReadWritTest(A,B,C,D,G) VALUES ('1922','146',null,'469','2563');

2847:DELETE FROM ConcurrentReadWritTest WHERE A = '2563’;

Found incorrect indexed data for the index tables by sqlline.

Debugged the mutations of batches on the server side. the DeleteColumns and Puts were splitted into the different batches for the once upsert,  the DeleteFaimly also was executed by another thread.  due to DeleteColumns's timestamp is larger than DeleteFaimly under multiple threads.

 

Running the following:

conn.createStatement().executeUpdate( "CREATE TABLE " + tableName + " (" + "A VARCHAR NOT NULL PRIMARY KEY," + "B VARCHAR," + "C VARCHAR," + "D VARCHAR) COLUMN_ENCODED_BYTES = 0"); 

conn.createStatement().executeUpdate("CREATE INDEX " + indexName + " on " + tableName + " (C) INCLUDE(D)"); 

conn.createStatement().executeUpdate("UPSERT INTO " + tableName + "(A,B,C,D) VALUES ('A2','B2','C2','D2')"); 
conn.createStatement().executeUpdate("UPSERT INTO " + tableName + "(A,B,C,D) VALUES ('A3','B3', 'C3', null)");

dump IndexMemStore:

hbase.index.covered.data.IndexMemStore(117): Inserting:\x01A3/0:D/1542190446218/DeleteColumn/vlen=0/seqid=0/value= phoenix.hbase.index.covered.data.IndexMemStore(133): Current kv state: phoenix.hbase.index.covered.data.IndexMemStore(135): KV: \x01A3/0:B/1542190446167/Put/vlen=2/seqid=5/value=B3 phoenix.hbase.index.covered.data.IndexMemStore(135): KV: \x01A3/0:C/1542190446167/Put/vlen=2/seqid=5/value=C3 phoenix.hbase.index.covered.data.IndexMemStore(135): KV: \x01A3/0:D/1542190446218/DeleteColumn/vlen=0/seqid=0/value= phoenix.hbase.index.covered.data.IndexMemStore(135): KV: \x01A3/0:_0/1542190446167/Put/vlen=1/seqid=5/value=x phoenix.hbase.index.covered.data.IndexMemStore(137): ========== END MemStore Dump ==================

 

The DeleteColumn's timestamp larger than other mutations.