Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4996

Refactor PTableImpl to use Builder Pattern

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.15.0, 5.1.0
    • None
    • None

    Description

      Currently PTableImpl has many constructor parameters, overloaded constructors as well as overloaded versions of makePTable which basically creates a new PTable itself. Because of this, constructing new PTable instances is becoming very difficult and error-prone. We should refactor this to use the builder pattern. This will improve usability and readability of the code at the cost of some amount of code repetition due to limitations of the builder pattern itself.

      Attachments

        1. PHOENIX-4996-4.x-HBase-1.3.patch
          144 kB
          Chinmay Kulkarni
        2. PHOENIX-4996-v1.patch
          144 kB
          Chinmay Kulkarni
        3. PHOENIX-4996.patch
          153 kB
          Chinmay Kulkarni

        Issue Links

          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. PHOENIX-2404 Create builder to construct PTableImpl

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link GitHub Pull Request #401

          Activity

            People

              ckulkarni Chinmay Kulkarni
              ckulkarni Chinmay Kulkarni
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: