Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4993

Data table region should not close RS level shared/cached connections like IndexWriter, RecoveryIndexWriter

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Resolved
    • 4.14.0
    • 4.15.0, 5.1.0, 4.14.2
    • None
    • None

    Description

      Issue is related to Region Server being killed when one region is closing and another region is trying to write index updates.

      When the data table region closes it will close region server level cached/shared connections and it could interrupt other region index/index-state update.

      – Region1: Closing

      TrackingParallellWriterIndexCommitter#stop() {
      
      this.retryingFactory.shutdown();
      
      this.noRetriesFactory.shutdown();
      
      }

      closes the cached connections calling CoprocessorHConnectionTableFactory#shutdown() in ServerUtil.java

       

      --Region2: Writing index updates

      Index updates fail as connections are closed, which leads to RejectedExecutionException/Connection being null. This triggers PhoenixIndexFailurePolicy#handleFailureWithExceptions that tries to get the the syscat table using the cached connections. Here it will not be able to reach to SYSCAT , so we will trigger KillServreFailurePolicy.

      CoprocessorHConnectionTableFactory#getTable()

       

       

      if (connection == null || connection.isClosed()) {
      
      throw new IllegalArgumentException("Connection is null or closed.");
      
      }

       

       

      Attachments

        1. PHOENIX-4993-master.addendum-1.patch
          2 kB
          Kiran Kumar Maturi
        2. PHOENIX-4993-master.02.patch
          6 kB
          Kiran Kumar Maturi
        3. PHOENIX-4993-master.01.patch
          6 kB
          Kiran Kumar Maturi
        4. PHOENIX-4993-4.x-HBase-1.3.05.patch
          7 kB
          Kiran Kumar Maturi
        5. PHOENIX-4993-4.x-HBase-1.3.04.patch
          7 kB
          Kiran Kumar Maturi
        6. PHOENIX-4993-4.x-HBase-1.3.03.patch
          7 kB
          Kiran Kumar Maturi
        7. PHOENIX-4993-4.x-HBase-1.3.02.patch
          7 kB
          Kiran Kumar Maturi
        8. PHOENIX-4993-4.x-HBase-1.3.01.patch
          10 kB
          Kiran Kumar Maturi

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kiran.maturi Kiran Kumar Maturi
            kiran.maturi Kiran Kumar Maturi
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment