[PHOENIX-4647] Column header doesn't handle optional arguments correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.14.0
• Fix Version/s: 4.15.0, 5.1.0
• Assignee: Xu Cang
• Reporter: Shehzaad Nakhoda
• Created: 09/Mar/18 08:34
• Updated: 21/Dec/19 00:53
• Resolved: 08/Aug/18 23:38

Description

SUBSTR(NAME, 1)
being rendered as
SUBSTR(NAME, 1, )

in things like column headings.

For example:
0: jdbc:phoenix:> create table hello_table (ID DECIMAL PRIMARY KEY, NAME VARCHAR);
No rows affected (1.252 seconds)
0: jdbc:phoenix:> upsert into hello_table values(1, 'abc');
1 row affected (0.025 seconds)
0: jdbc:phoenix:> select substr(name, 1) from hello_table;
--------------------

SUBSTR(NAME, 1, )

--------------------

abc

--------------------

Looks to me like there's a bug -
SUBSTR(NAME, 1) should be represented as SUBSTR(NAME, 1) not as SUBSTR(NAME, 1, )