[PHOENIX-4467] Scans with filter returning all the versions

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0-alpha
• Labels: HBase-2.0
• Assignee: Ankit Singhal
• Reporter: Ankit Singhal
• Created: 18/Dec/17 14:51
• Updated: 09/Jan/18 07:50
• Resolved: 09/Jan/18 07:50

Description

Even if we set max versions in the scan to 1, HBase is still returning all the versions if there is a filter.
It seems to be a side-effect of HBASE-17125. where if INCLUDE_AND_NEXT_COL is the return code from the filter, we are not checking the version of the cell even though the documentation says.

@InterfaceAudience.Public
  public enum ReturnCode {
    /**
     * Include the Cell
     */
    INCLUDE,
    /**
     * Include the Cell and seek to the next column skipping older versions.
     */
    INCLUDE_AND_NEXT_COL,

}

In UserScanQueryMatcher#mergeFilterResponse()

case INCLUDE_AND_NEXT_COL:
        if (matchCode == MatchCode.INCLUDE) {
          matchCode = MatchCode.INCLUDE_AND_SEEK_NEXT_COL;
        }
        break;
 if (matchCode == MatchCode.INCLUDE_AND_SEEK_NEXT_COL
        || matchCode == MatchCode.INCLUDE_AND_SEEK_NEXT_ROW) {
      return matchCode;
    }

    // Now we will check versions again.
    if (curColCell == null || !CellUtil.matchingRowColumn(cell, curColCell)) {
      count = 0;
      curColCell = cell;
    }
    count += 1;
    return count > versionsAfterFilter ? MatchCode.SEEK_NEXT_COL : MatchCode.INCLUDE;

anoopsamjohn, It could be a bug in HBase