[PHOENIX-4277] Treat delete markers consistently with puts for point-in-time scans

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.13.0
• Labels: rowDeletion
• Assignee: James R. Taylor
• Reporter: James R. Taylor
• Created: 04/Oct/17 21:07
• Updated: 14/Aug/20 16:53
• Resolved: 30/Oct/17 16:13

Description

The IndexScrutinyTool relies on doing point-in-time scans to determine consistency between the index and data tables. Unfortunately, deletes to the tables cause a problem with this approach, since delete markers take effect even if they're at a later time stamp than the point-in-time at which the scan is being done (unless KEEP_DELETED_CELLS is true). The logic of this is that scans should get the same results before and after a compaction take place.

Taking snapshots does not help with this since they cannot be taken at a point-in-time and the delete markers will act the same way - there's no way to guarantee that the index and data table snapshots have the same "logical" set of data.

Using raw scans would allow us to see the delete markers and do the correct point-in-time filtering ourselves. We'd need to write the filters to do this correctly (see the Tephra TransactionVisibilityFilter for an implementation of this that could be adapted). We'd also need to hook this into Phoenix or potentially dip down to the HBase level to do this.

Thanks for brainstorming on this with me, lhofhansl.

Issue Links

• causes: PHOENIX-4630 Reverse scan with row_timestamp does not working
• is part of: PHOENIX-5881 Port MaxLookbackAge logic to 5.x
• relates to: PHOENIX-5637 Queries with SCN return expired rows
• relates to: PHOENIX-4378 Unable to set KEEP_DELETED_CELLS to true on RS scanner