Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4066

Unused variable in MutationState.send()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 4.11.0
    • 4.12.0
    • None

    Description

      In MutationState#send, we always allocate the following:

      List<TableRef> txTableRefs = Lists.newArrayListWithExpectedSize(mutations.size());

      and if a table's transactional, we populate it:

      txTableRefs.add(origTableRef);`

      but this is never referred to again in either logic or logging, and it's a local variable so we can't be using it elsewhere either. It should be removed or used (and if used, it should only be allocated in the transactional use case.)

      Attachments

        1. PHOENIX-4066.patch
          2 kB
          Geoffrey Jacoby

        Activity

          People

            gjacoby Geoffrey Jacoby
            gjacoby Geoffrey Jacoby
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: