[PHOENIX-3997] UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check the memstore size and wait for flush.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.12.0
• Assignee: Geoffrey Jacoby
• Reporter: Thomas D'Silva
• Created: 06/Jul/17 18:36
• Updated: 26/Jul/17 05:28
• Resolved: 24/Jul/17 23:24

Description

ankit.singhal

In UngroupedAggregateRegionObserver.commitBatchWithHTable() do we need to check the memstore size and wait for the flush. We are using a htable to write the mutations.

 // When memstore size reaches blockingMemstoreSize we are waiting 3 seconds for the
        // flush happen which decrease the memstore size and then writes allowed on the region.
        for (int i = 0; region.getMemstoreSize().get() > blockingMemstoreSize && i < 30; i++) {
            try {
                checkForRegionClosing();
                Thread.sleep(100);
            } catch (InterruptedException e) {
                Thread.currentThread().interrupt();
                throw new IOException(e);
            }
        }
        logger.debug("Committing batch of " + mutations.size() + " mutations for " + table);
        try {
            table.batch(mutations);
        } catch (InterruptedException e) {
            throw new RuntimeException(e);
        }

FYI jamestaylor apurtell

Issue Links

• relates to: PHOENIX-3986 UngroupedAggregateRegionObserver.commitBatch() should set the index metadata as an attribute on every mutation