Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-3531

Apply integration tests to the queryserver

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 4.8.0
    • Fix Version/s: None
    • Component/s: None

      Description

      We can add queryserver tests that extend the direct tests.
      ie. QueryServerLikeExpressionIT extends LikeExpressionIT.

      `getUrl` needs to be overridden to access the test cluster through the queryserver. We can't override static methods or fields (but getUrl needs to be static because in many cases it is used in @BeforeClass) but we could use dependency injection to inject a url-holder. This way, the QueryServer~IT tests will be shell classes that simply override initialization of the url-holder.

      This could effectively double the amount of time taken to run integration tests.

      Any objections to using dependency injection - or alternative solutions? Should we replicate tests across the board or selectively?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                kliew Kevin Liew
                Reporter:
                kliew Kevin Liew
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: